-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(List Converter): remove prefix/suffix capability, split, sort #1302
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1834c51
to
56d779e
Compare
56d779e
to
327ff11
Compare
Hi @sharevb I have tested it a little bit and it does what it should do! 👏🏼 But I have two findings which are also present in the original tool. Might be good to fix them:
|
@sharevb according to Sonarcloud there are 4 new issues. Want to take a look at them and fix it? |
e942c38
to
4043c9e
Compare
1c74cdd
to
8952a26
Compare
8952a26
to
2b761c7
Compare
2b761c7
to
97bb2e3
Compare
97bb2e3
to
cde70bc
Compare
cde70bc
to
51cde85
Compare
51cde85
to
59a5485
Compare
HI @steffenrapp, corrected |
Hi @steffenrapp, all those corrected, added some sorting and splitting (and better UI in small screen) |
Hi @sharevb Looks good to me :) |
9491b22
to
7bafd47
Compare
Fix CorentinTh#764 CorentinTh#1279 CorentinTh#1090 Small screen UI Fix
@sharevb is attempting to deploy a commit to the Corentin Thomasset's Team Team on Vercel. A member of the Team first needs to authorize it. |
Quality Gate passedIssues Measures |
Hi @sharevb I'd like to test your changes but it's not possible as the preview isn't generated anymore 🤷🏻♂️ |
Remove prefix/suffix : fix #702
No sort bug : fix #764
Splitting : fix #1090 #1279
Small screen UI Fix
LIst prefix/suffix bug
Sort by numeric : fix #1089